test(rsc): add transitive cjs dep example #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
deleted the
07-22-feat_rsc_auto_optimize_use-sync-external-store_in_transitive_deps
branch
hi-ogawa
restored the
07-22-feat_rsc_auto_optimize_use-sync-external-store_in_transitive_deps
branch
|
This "deep cjs" example seems useful, so let add this as a test case for starter. |
hi-ogawa
changed the title
…al-store_in_transitive_deps
Updates naming to better reflect the nature of CommonJS dependencies that are transitively imported through other packages. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
hi-ogawa
deleted the
07-22-feat_rsc_auto_optimize_use-sync-external-store_in_transitive_deps
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
optimizeDeps.includeheuristics to ensure popular cjs packages to be automatically optimized #610For now this only added a test case. It might look like this is too specific heuristics, but why not.
It looks like vitefu doesn't support this use case, so we need to write
crawlFrameworkPkgson our own https://github.com/svitejs/vitefu/blob/d8d82fa121e3b2215ba437107093c77bde51b63b/src/index.js#L23I don't think this is important, so closing for now.